Rebuild cached failures on proper workers #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erethon
force-pushed
the
fix-cached-failures-rebuild
branch
from
332e27e to
2b4cd17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user triggers a rebuild for a cached failure, this runs on one of the
SKIPPED_BUILDER_NAMESworkers which I believe don't have a proper PATH and end up failing because the worker can't find the nix binary. You can see one such failed rebuild in the NGI buildbot here.In order to keep the skipped builders setup as simple as possible, I've opted to add a trigger for a complete
nix-evalin such cases (which should go to our regular builders). Running justnix-buildcould fail if drvs had been GC'ed (or I guess with multiple workers and not a singular cache).I'm not sure if there's a better way to do this in buildbot, if there are better ideas let me know and I can try to implement them. The current implementation works in my testing.